Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

check-manifest is broken #7403

Closed
richvdh opened this issue May 4, 2020 · 2 comments
Closed

check-manifest is broken #7403

richvdh opened this issue May 4, 2020 · 2 comments
Assignees
@babolivier

Comments

@richvdh
Copy link
Member

richvdh commented May 4, 2020

No description provided.

@babolivier babolivier added the Z-Upstream-Bug This issue requires a fix in an upstream dependency. label May 4, 2020
@babolivier
Copy link
Contributor

Related changes: https://github.com/mgedmin/check-manifest/blob/master/CHANGES.rst#042-2020-05-03

@babolivier babolivier removed the Z-Upstream-Bug This issue requires a fix in an upstream dependency. label May 4, 2020
@babolivier babolivier self-assigned this May 4, 2020
@babolivier babolivier mentioned this issue May 4, 2020
Merged
babolivier added a commit that referenced this issue May 4, 2020
@babolivier
Fix MANIFEST.in
068da60 
An update of check-manifest shone some light on some issues with MANIFEST.in, specifically that we didn't ignore/prune the contrib directory, and that we were using prune instead of exclude for files. This fixes both issues.

Fixes #7403
@babolivier
Copy link
Contributor

Fixed in #7404

phil-flex pushed a commit to phil-flex/synapse that referenced this issue Jun 16, 2020
@babolivier @phil-flex
Fix MANIFEST.in
b4b714f 
An update of check-manifest shone some light on some issues with MANIFEST.in, specifically that we didn't ignore/prune the contrib directory, and that we were using prune instead of exclude for files. This fixes both issues.

Fixes matrix-org#7403
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@babolivier babolivier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @babolivier