Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

make CI reject patches with DOS line endings #7943

Closed
richvdh opened this issue Jul 24, 2020 · 2 comments
Closed

make CI reject patches with DOS line endings #7943

richvdh opened this issue Jul 24, 2020 · 2 comments
Assignees
@anoadragon453

Comments

@richvdh
Copy link
Member

richvdh commented Jul 24, 2020

for some reason, some of the files in #7613 have DOS line endings
@anoadragon453 anoadragon453 mentioned this issue Jul 24, 2020
Merged
@anoadragon453
Copy link
Member

anoadragon453 commented Jul 24, 2020 •
edited
Loading

#7953 and matrix-org/pipelines#81 should be what's needed.

Edit: #7965 has been sprouted to add a checking script to the Synapse repo.

@anoadragon453 anoadragon453 self-assigned this Jul 24, 2020
@anoadragon453 anoadragon453 mentioned this issue Jul 27, 2020
Merged
anoadragon453 added a commit that referenced this issue Jul 28, 2020
@anoadragon453
Add script for finding files with unix line terminators (#7965)
c4ce0da 
This PRs adds a script to check for unix-line terminators in the repo. It will be used to address #7943 by adding the check to CI.

I've changed the original script slightly as proposed in matrix-org/pipelines#81 (comment)
richvdh pushed a commit to matrix-org/pipelines that referenced this issue Jul 28, 2020
@anoadragon453
Synapse: Add step to check for unix file endings (#81)
6df6b76 
To address matrix-org/synapse#7943. I'm using the python:3.6 image for consistency, but this would probably run on alpine.
@richvdh
Copy link
Member Author

richvdh commented Jul 28, 2020

done by #7965

@richvdh richvdh closed this as completed Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anoadragon453 anoadragon453

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anoadragon453 @richvdh