Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

duplicated rows in user_daily_visits #8641

Closed
richvdh opened this issue Oct 23, 2020 · 1 comment
Closed

duplicated rows in user_daily_visits #8641

richvdh opened this issue Oct 23, 2020 · 1 comment
Assignees
@erikjohnston
Labels
z-bug (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Oct 23, 2020

I think it's supposed to only contain one row per (user_id, device_id, timestamp), but in practice each different user_agent seems to get its own row.
@richvdh
Copy link
Member Author

richvdh commented Oct 23, 2020

seems to have been introduced in https://github.com/matrix-org/synapse/pull/8503/files#diff-dd317c99e1c729e92c1e18959071bcc73b19fc5051db0a4cfc0e0c70bbdc7bf5R291-R302.

(might be worth adding a unique constraint to enforce this)

@erikjohnston erikjohnston self-assigned this Oct 26, 2020
@erikjohnston erikjohnston added the z-bug (Deprecated Label) label Oct 26, 2020
erikjohnston added a commit that referenced this issue Oct 26, 2020
@erikjohnston
Fix user_daily_visits to not have duplicate rows for UA.
8db622f 
Fixes #8641.
@erikjohnston erikjohnston mentioned this issue Oct 26, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@erikjohnston erikjohnston

Labels
z-bug (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @erikjohnston