Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

OIDC: allow individual endpoints to be overridden without disabling discovery #9347

Closed
richvdh opened this issue Feb 8, 2021 · 1 comment · Fixed by #9384
Closed

OIDC: allow individual endpoints to be overridden without disabling discovery #9347

richvdh opened this issue Feb 8, 2021 · 1 comment · Fixed by #9384
Labels
A-Social Login Login via external identity providers T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@richvdh
Copy link
Member

richvdh commented Feb 8, 2021

It's sometimes useful to be able to tweak individual endpoints for the OpenID Connect auth provider, for example to add additional parameters to the "authentication" API. One example is for Google, which specifies a prompt parameter telling Google to let the user pick between one of their accounts.

Currently the only way for an admin to add these parameters is by disabling discovery and manually configuring all of the OAuth2 endpoints. I think we should reverse this and make configured endpoints override any discovered ones.

@richvdh
Copy link
Member Author

richvdh commented Feb 8, 2021

somewhat related to #9309

@erikjohnston erikjohnston added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Feb 9, 2021
richvdh added a commit that referenced this issue Feb 9, 2021
richvdh added a commit that referenced this issue Feb 11, 2021
@richvdh richvdh added the A-Social Login Login via external identity providers label Feb 11, 2021
richvdh added a commit that referenced this issue Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Social Login Login via external identity providers T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants