Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use inline type hints in handlers/ and rest/ #10382

Merged
merged 5 commits into from
Jul 16, 2021
Merged

Use inline type hints in handlers/ and rest/ #10382

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c315e75
handlers and rest
ShadowJonathan Jul 13, 2021
84ffa74
changelog
ShadowJonathan Jul 13, 2021
454a405
fix some more type annotations
ShadowJonathan Jul 13, 2021
b846ba2
review feedback
ShadowJonathan Jul 16, 2021
09a6ad1
please the almighty mypy
ShadowJonathan Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion synapse/rest/media/v1/media_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def __init__(self, hs: "HomeServer"):
Thumbnailer.set_limits(self.max_image_pixels)

self.primary_base_path: str = hs.config.media_store_path
self.filepaths = MediaFilePaths(self.primary_base_path)
self.filepaths: MediaFilePaths = MediaFilePaths(self.primary_base_path)
ShadowJonathan marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason mypy wasn't able to infer this after i removed it :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's odd, but let's just leave it for now.


self.dynamic_thumbnails = hs.config.dynamic_thumbnails
self.thumbnail_requirements = hs.config.thumbnail_requirements
Expand Down