Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Deduplicate concurrent requests to get_state_for_groups #10681

Closed
wants to merge 8 commits into from

Conversation

reivilibre
Copy link
Contributor

Closes #10510. Closes #10301.

@reivilibre reivilibre marked this pull request as ready for review August 24, 2021 09:40
@reivilibre reivilibre marked this pull request as draft August 24, 2021 09:41
@reivilibre
Copy link
Contributor Author

This is a draft reincarnation of #10510.

I don't fully like it. It feels like it should be possible to do something simpler, but there are quite a few cases to consider (mostly due to the include_others flag on StateFilters). That said, I haven't come up with anything I like more so far.

I will write tests for this, because I feel like it really needs them to exercise all the conditions, but I was hoping to ask for advice on this before I sink the effort to write some tests in (though maybe that's not such a concern since they might be reusable?).

@reivilibre reivilibre changed the title Deduplicate concurrent requests to get_state_group_from_groups Deduplicate concurrent requests to get_state_for_groups Aug 25, 2021
@erikjohnston
Copy link
Member

I think @reivilibre was going to try and tidy up the commits a bit and then re-request review

@erikjohnston erikjohnston removed their request for review September 6, 2021 12:54
@erikjohnston erikjohnston marked this pull request as ready for review September 9, 2021 13:09
@erikjohnston
Copy link
Member

@reivilibre and I had a chat about this and we're changing the way we cache things a bit to avoid having a new type of cache.

@erikjohnston erikjohnston removed their request for review September 10, 2021 12:39
@reivilibre reivilibre closed this Sep 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

many duplicate _get_state_groups_from_groups queries leading to OOMs
2 participants