This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Disable registration by default. Add script to register new users. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| else: | ||
| raise SynapseError( | ||
| 400, "HMAC incorrect", |
There was a problem hiding this comment.
This seems like it should be a 403 to me.
| def _do_shared_secret(self, request, register_json, session): | ||
| yield run_on_reactor() | ||
|
|
||
| if "mac" not in register_json: |
There was a problem hiding this comment.
Given register_json is just a dict from JSON, users may not be setting the right types of these keys. We should be type checking here, which we can actually do in one fell swoop with checking for the existence of keys by doing isinstance(register_json.get("mac"), basestring)
|
LGTM other than in-line comments. |
|
LGTM |
erikjohnston
added a commit
that referenced
this pull request
Mar 18, 2015
Disable registration by default. Add script to register new users.
babolivier
added a commit
that referenced
this pull request
Nov 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also implements a non-standard registration type that uses shared secret.