Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Check auth on received events' auth_events #11001

Merged
merged 6 commits into from
Oct 18, 2021
Merged

Check auth on received events' auth_events #11001

merged 6 commits into from
Oct 18, 2021

Commits on Oct 6, 2021

  1. Check *all* auth events for room id and rejection 

    This fixes a bug where we would accept an event whose `auth_events` include
rejected events, if the rejected event was shadowed by another `auth_event`
with same `(type, state_key)`.

The approach is to pass a list of auth events into
`check_auth_rules_for_event` instead of a dict, which of course means updating
the call sites.

This is an extension of #10956.
    @richvdh
    richvdh committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    5cd2255 View commit details
    Browse the repository at this point in the history

  2. Make sure we have the auth_events of any received event 

    When authing non-outlier events, make sure that we have the `auth_events` of
those events - and refuse to process any that we do not.
    @richvdh
    richvdh committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    a53b1a0 View commit details
    Browse the repository at this point in the history

  3. Check auth on auth_events for incoming events 

    All events must pass auth based on their auth events
    @richvdh
    richvdh committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    2e64051 View commit details
    Browse the repository at this point in the history

  4. add a comment

    @richvdh
    richvdh committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    1dd6077 View commit details
    Browse the repository at this point in the history

  5. minor logging tweak

    @richvdh
    richvdh committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    f2b011d View commit details
    Browse the repository at this point in the history

  6. changelog

    @richvdh
    richvdh committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    0ce88de View commit details
    Browse the repository at this point in the history