This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Relax ignore-missing-imports
for modules that have stubs now and update mypy
#11006
Merged
Commits on Oct 6, 2021
-
Alphabetise mypy
ignore-missing-imports
sectionDavid Robertson committedOct 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 2665e77 - Browse repository at this point
Copy the full SHA 2665e77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05bd370 - Browse repository at this point
Copy the full SHA 05bd370View commit details -
since at least here: python/typeshed#5649 Two fixups to keep mypy happy. The first handles that `get_notAfter` could return None. Before this would raise a generic `AttributeError`; now it raises a ValueError with specific message. The second ensures the callback to `set_verify` returns bool, not NoneType. (AFAICS this was fine because PyOpenSSL only ever used the truthiness of the callback's return value.)
David Robertson committedOct 6, 2021 Configuration menu - View commit details
-
Copy full SHA for faa1f10 - Browse repository at this point
Copy the full SHA faa1f10View commit details -
Had to make some more invasive changes to our media code. I replaced our naughty calls to `_getdecoder` with calls to [check_codec], introduced about seven years ago. [check_codec]: python-pillow/Pillow@799e831 mypy didn't like our use of `_getexif`. The [Pillow 3.1.0 release notes][pillow-3.1] describe this as > private, experimental, but generally widely used There's a public `getexif()` without an underscore, but that's only available since [Pillow 6.0.0][pillow-6] [pillow-3.1]: https://pillow.readthedocs.io/en/stable/releasenotes/3.1.0.html#jpegimageplugin-getexif [pillow-6]: https://pillow.readthedocs.io/en/stable/releasenotes/6.0.0.html#added-exif-class
David Robertson committedOct 6, 2021 Configuration menu - View commit details
-
Copy full SHA for db6001f - Browse repository at this point
Copy the full SHA db6001fView commit details -
Comment about the possibility of stubs existing
David Robertson committedOct 6, 2021 Configuration menu - View commit details
-
Copy full SHA for e4a27c1 - Browse repository at this point
Copy the full SHA e4a27c1View commit details -
David Robertson committed
Oct 6, 2021 Configuration menu - View commit details
-
Copy full SHA for eec2cb0 - Browse repository at this point
Copy the full SHA eec2cb0View commit details -
pacakge->package, thanks Patrick!
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for df7ffe5 - Browse repository at this point
Copy the full SHA df7ffe5View commit details
Commits on Oct 7, 2021
-
Bump mypy version and pull in additional stubs
I'm not sure why newer mypy requires these---perhaps it's a consequence of pulling in a newer mypy-zope?
David Robertson committedOct 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 3844414 - Browse repository at this point
Copy the full SHA 3844414View commit details -
Make mypy happy by referring to struct_rusage
I think struct_rusage has existed for a couple of decades now, see https://github.com/python/cpython/blame/bb3e0c240bc60fe08d332ff5955d54197f79751c/Modules/resource.c#L32
David Robertson committedOct 7, 2021 Configuration menu - View commit details
-
Copy full SHA for ec73d78 - Browse repository at this point
Copy the full SHA ec73d78View commit details -
David Robertson committed
Oct 7, 2021 Configuration menu - View commit details
-
Copy full SHA for e3e8756 - Browse repository at this point
Copy the full SHA e3e8756View commit details -
David Robertson committed
Oct 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 4d0bc24 - Browse repository at this point
Copy the full SHA 4d0bc24View commit details -
David Robertson committed
Oct 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 79fcc8c - Browse repository at this point
Copy the full SHA 79fcc8cView commit details
Commits on Oct 8, 2021
-
David Robertson committed
Oct 8, 2021 Configuration menu - View commit details
-
Copy full SHA for e2ec76b - Browse repository at this point
Copy the full SHA e2ec76bView commit details -
Explicit error for
spec is None
David Robertson committedOct 8, 2021 Configuration menu - View commit details
-
Copy full SHA for 57ba17d - Browse repository at this point
Copy the full SHA 57ba17dView commit details -
David Robertson committed
Oct 8, 2021 Configuration menu - View commit details
-
Copy full SHA for 6630fa2 - Browse repository at this point
Copy the full SHA 6630fa2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.