Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix formatting string when oEmbed errors occur. #11061

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Fix formatting string when oEmbed errors occur. #11061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5da7fbb
Fix formatting string when oEmbed errors occur.
clokep Oct 12, 2021
e6497c1
Newsfragment
clokep Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/11061.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug introduced in Synapse v1.44.0 when logging errors during oEmbed processing.
2 changes: 1 addition & 1 deletion synapse/rest/media/v1/oembed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def parse_oembed_response(self, url: str, raw_body: bytes) -> OEmbedResult:

except Exception as e:
# Trap any exception and let the code follow as usual.
logger.warning(f"Error parsing oEmbed metadata from {url}: {e:r}")
logger.warning("Error parsing oEmbed metadata from %s: %r", url, e)
open_graph_response = {}
cache_age = None

Expand Down