Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add/Unerase annotations to Module API #11341

Merged
merged 5 commits into from
Nov 18, 2021
Merged

Add/Unerase annotations to Module API #11341

merged 5 commits into from
Nov 18, 2021

Commits on Nov 15, 2021

  1. Add some drive-by type annotations

    @reivilibre
    reivilibre committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    a926b40 View commit details
    Browse the repository at this point in the history

  2. Fix method type erasure by not using @Property 

    Unfortunately, specifying the method type as the property's
return type is not feasible because it is not possible to
specify keyword arguments in Callables.
The only alternative for now is to use Mypy-specific extensions,
but that would probably be uglier than just expanding this
function.
    @reivilibre
    reivilibre committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    282c245 View commit details
    Browse the repository at this point in the history

  3. Newsfile 

    Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
    @reivilibre
    reivilibre committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    8d72213 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Merge branch 'develop' into rei/module_api_anno

    @reivilibre
    reivilibre committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    f2221ed View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Incorporate review feedback

    @reivilibre
    reivilibre committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    81393b6 View commit details
    Browse the repository at this point in the history