Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Make get_device return None if the device doesn't exist rather than raising an exception. #11565

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Make get_device return None if the device doesn't exist rather than raising an exception. #11565

merged 4 commits into from
Dec 13, 2021

Commits on Dec 13, 2021

  1. Make get_device return Optional rather than raising

    @reivilibre
    reivilibre committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    1da98c8 View commit details
    Browse the repository at this point in the history

  2. Preserve the original behaviour

    @reivilibre
    reivilibre committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    f9ad151 View commit details
    Browse the repository at this point in the history

  3. Newsfile 

    Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
    @reivilibre
    reivilibre committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    9a1df2e View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
    @reivilibre @squahtx
    reivilibre and squahtx committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    f9b1451 View commit details
    Browse the repository at this point in the history