Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Cap the number of in-flight requests for state from a single group #11608

Merged
merged 9 commits into from
Feb 22, 2022

Conversation

reivilibre
Copy link
Contributor

Small incremental change above #10870 that prevents too many concurrent requests being in-flight for a single state group, by just requesting the whole state filter from the database.

Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
@reivilibre reivilibre marked this pull request as ready for review February 18, 2022 17:33
@reivilibre reivilibre requested a review from a team as a code owner February 18, 2022 17:33
@clokep
Copy link
Member

clokep commented Feb 18, 2022

Do we want a test for this?

@reivilibre reivilibre requested a review from clokep February 21, 2022 14:58
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK overall, just a couple confusing comments!

tests/storage/databases/test_state_store.py Outdated Show resolved Hide resolved
tests/storage/databases/test_state_store.py Outdated Show resolved Hide resolved
tests/storage/databases/test_state_store.py Outdated Show resolved Hide resolved
@reivilibre reivilibre merged commit dcb6a37 into develop Feb 22, 2022
@reivilibre reivilibre deleted the rei/stcache_cap branch February 22, 2022 14:24
reivilibre added a commit that referenced this pull request Mar 1, 2022
reivilibre added a commit that referenced this pull request Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants