This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally use an on-disk sqlite db in tests #11702
Optionally use an on-disk sqlite db in tests #11702
Changes from all commits
b538f33
9114f2b
6c1a8dd
47e07c2
24c50d5
1753a6b
547874a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually do
str(os.environ.get(...)).lower() == "true"
to make it a bit tighter... 🤷 but who knows what the right value is here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
str(...)
--- are the values bytes by default?Come to think of it, maybe I could do
"VARNAME" in os.environ
, since I'm only interested in if it's set or not. I'll probably leave it be for now though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes
None
->"None"
😄This is only really useful if you want to ensure that
true
-ish string values are used.