Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

CI: run Complement on the VM, not inside Docker #11811

Merged
merged 7 commits into from
Jan 25, 2022
Merged

CI: run Complement on the VM, not inside Docker #11811

merged 7 commits into from
Jan 25, 2022

Commits on Jan 24, 2022

  1. CI: run Complement on the VM, not inside Docker

    This requires matrix-org/complement#289
    
    We now run Complement on the VM instead of inside a Docker container.
    This is to allow Complement to bind to any high-numbered port when it
    starts up its own federation servers. We want to do this to allow for
    more concurrency when running complement tests. Previously, Complement
    only ever bound to `:8448` when running its own federation server. This
    prevented multiple federation tests running at the same time as they would
    fight each other on the port. This did however allow Complement to run
    in Docker, as the host could just port forward `:8448` to allow homeserver
    containers to communicate to Complement. Now that we are using random
    ports however, we cannot use Docker to run Complement. This ends up
    being a good thing because:
     - Running Complement tests locally is closer to how they run in CI.
     - Allows the `CI` env var to be removed in Complement.
     - Slightly speeds up runs as we don't need to pull down the Complement
       image prior to running tests. This assumes GHA caches actions sensibly.
    kegsay committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    a95183a View commit details
    Browse the repository at this point in the history
  2. Changelog

    kegsay committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    030c580 View commit details
    Browse the repository at this point in the history
  3. Full stop

    kegsay committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    2072e19 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Update .github/workflows/tests.yml

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    kegsay and richvdh authored Jan 25, 2022
    Configuration menu
    Copy the full SHA
    b1b5cf8 View commit details
    Browse the repository at this point in the history
  2. Review comments

    kegsay committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    9b23cc5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a1bd14a View commit details
    Browse the repository at this point in the history
  4. Update .github/workflows/tests.yml

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    kegsay and richvdh authored Jan 25, 2022
    Configuration menu
    Copy the full SHA
    f5834f6 View commit details
    Browse the repository at this point in the history