This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Printf debugging for MSISDN validation #11882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
force-pushed
the
dmr/msis-debug-n
branch
from
f45ebb4
to
574b4ff
Compare
babolivier
suggested changes
Feb 3, 2022
synapse/rest/client/account.py
Outdated
Comment on lines
471
to
474
| # Didn't like the sound of logging `client_secret`, but the spec says it is | ||
| # "A unique string generated by the client, and used to identify the validation | ||
| # attempt." I.e. something to facilitate deduplication. I don't think it's a | ||
| # sensitive secret per se. |
There was a problem hiding this comment.
It's not so much used to deduplicate but rather to make sure the next request(s) come from the client that started the process. I'm not sure what amount of harm can be done if someone gets a hold of someone else's client secret, but my paranoid self would prefer being cautious and not logging it if we don't need it.
There was a problem hiding this comment.
Thanks, I didn't grok that it was to be sent in another request.
synapse/rest/client/account.py
Outdated
| @@ -518,6 +525,7 @@ async def on_POST(self, request: SynapseRequest) -> Tuple[int, JsonDict]: | |||
| threepid_send_requests.labels(type="msisdn", reason="add_threepid").observe( | |||
| send_attempt | |||
| ) | |||
| logger.info("MSISDN %s is already in use by %s", msisdn, existing_user_id) | |||
There was a problem hiding this comment.
This doesn't look like it's in the right place?
There was a problem hiding this comment.
no, looks like a copy paste fail. thanks.
added 2 commits
February 3, 2022 18:34
|
I'm assuming the CI failing might fixed by #11906 |
babolivier
approved these changes
Feb 4, 2022
DMRobertson
pushed a commit
that referenced
this pull request
Feb 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose committing this, running it on m.org's master for a bit, then reverting once we're sufficiently confident in the results.