Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Notify users, rather than rooms, of device list updates #11905

Merged
merged 4 commits into from
Feb 12, 2022
Merged

Notify users, rather than rooms, of device list updates #11905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a01250
Re-use calculated list of users before notifying through on_new_event
anoadragon453 Feb 3, 2022
3d42f01
changelog
anoadragon453 Feb 3, 2022
d4daf3e
Pass the correct collection to union
anoadragon453 Feb 4, 2022
4858a61
Update changelog.d/11905.misc
anoadragon453 Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/11905.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Preparation to support sending device list updates to application services.
8 changes: 3 additions & 5 deletions synapse/handlers/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,13 +495,11 @@ async def notify_device_update(
"Notifying about update %r/%r, ID: %r", user_id, device_id, position
)

room_ids = await self.store.get_rooms_for_user(user_id)

# specify the user ID too since the user should always get their own device list
# updates, even if they aren't in any rooms.
self.notifier.on_new_event(
"device_list_key", position, users=[user_id], rooms=room_ids
)
users_to_notify = users_who_share_room.union({user_id})

self.notifier.on_new_event("device_list_key", position, users=users_to_notify)

if hosts:
logger.info(
Expand Down