Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use importlib.metadata to read requirements #12088

Merged
merged 9 commits into from
Mar 1, 2022

Commits on Feb 25, 2022

  1. Pull runtime dep checks into their own module

    David Robertson committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    e49fd50 View commit details
    Browse the repository at this point in the history
  2. Changelog

    David Robertson committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    94ddc49 View commit details
    Browse the repository at this point in the history
  3. Reimplement check_requirements using importlib

    I've tried to make this clearer. We start by working out which of
    Synapse's requirements we need to be installed here and now. I was
    surprised that there wasn't an easier way to see which packages were
    installed by a given extra.
    
    I've pulled out the error messages into functions that deal with "is
    this for an extra or not". And I've rearranged the loop over two
    different sets of requirements into one loop with a "must be instaled"
    flag.
    
    I hope you agree that this is clearer.
    David Robertson committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    d88bab5 View commit details
    Browse the repository at this point in the history
  4. Type hints for existing code

    David Robertson committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    51e76ec View commit details
    Browse the repository at this point in the history
  5. Test cases

    David Robertson committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    c7eee4f View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Use .get_all; add distribution pkg name constant

    David Robertson committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    9bed98f View commit details
    Browse the repository at this point in the history
  2. needed -> unfulfilled

    David Robertson committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    903e95c View commit details
    Browse the repository at this point in the history
  3. isort && flake8

    David Robertson committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    40dbcb2 View commit details
    Browse the repository at this point in the history
  4. And fix an extra newline

    David Robertson committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    24a4b54 View commit details
    Browse the repository at this point in the history