Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Optimise _update_client_ips_batch_txn to batch together database operations. #12252

Merged
merged 25 commits into from
Apr 8, 2022
Merged

Optimise _update_client_ips_batch_txn to batch together database operations. #12252

merged 25 commits into from
Apr 8, 2022

Commits on Apr 6, 2022

  1. Upsert many client IPs at once, more efficiently

    @reivilibre
    reivilibre committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    7cf8b2e View commit details
    Browse the repository at this point in the history

  2. Newsfile 

    Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
    @reivilibre
    reivilibre committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    c7cfbf5 View commit details
    Browse the repository at this point in the history

  3. Add a simple update many txn

    @reivilibre
    reivilibre committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    45c98e0 View commit details
    Browse the repository at this point in the history

  4. Add non-txn simple update many

    @reivilibre
    reivilibre committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    0646b4b View commit details
    Browse the repository at this point in the history

  5. Use simple_update_many for devices

    @reivilibre
    reivilibre committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1acd8cd View commit details
    Browse the repository at this point in the history

  6. Isolate locals by splitting into two smaller functions

    @reivilibre
    reivilibre committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1e961ad View commit details
    Browse the repository at this point in the history

  7. Make _dump_to_tuple dump the entire table without undue ceremony

    @reivilibre
    reivilibre committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    503f5c8 View commit details
    Browse the repository at this point in the history

  8. Rename some things to clarify

    @reivilibre
    reivilibre committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    5f29099 View commit details
    Browse the repository at this point in the history

  9. Add a test for simple_update_many

    @reivilibre
    reivilibre committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    e7c4907 View commit details
    Browse the repository at this point in the history

  10. Add an exception for when the number of value rows and key rows don't… 

    … match
    @reivilibre
    reivilibre committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    5675a94 View commit details
    Browse the repository at this point in the history

  11. Antilint

    @reivilibre
    reivilibre committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    e7985d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Add lock=True for the emulated many-upsert case

    @reivilibre
    reivilibre committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    7edf6f7 View commit details
    Browse the repository at this point in the history

  2. Don't double-lock the table

    @reivilibre
    reivilibre committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    9556aae View commit details
    Browse the repository at this point in the history

  3. Inline column names

    @reivilibre
    reivilibre committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    303fba6 View commit details
    Browse the repository at this point in the history

  4. Flatten user_ips builder

    @reivilibre
    reivilibre committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    ac4b1d5 View commit details
    Browse the repository at this point in the history

  5. Flatten devices builder

    @reivilibre
    reivilibre committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    34403cb View commit details
    Browse the repository at this point in the history

  6. Fix up docstring

    @reivilibre
    reivilibre committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    0f8e98b View commit details
    Browse the repository at this point in the history

  7. Remove dead variable

    @reivilibre
    reivilibre committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    481b730 View commit details
    Browse the repository at this point in the history

  8. Don't return for None

    @reivilibre
    reivilibre committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    99e6b66 View commit details
    Browse the repository at this point in the history

  9. Update synapse/storage/database.py 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @reivilibre @clokep
    reivilibre and clokep committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    3f7f659 View commit details
    Browse the repository at this point in the history

  10. Bail out when there's nothing to do

    @reivilibre
    reivilibre committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    50f2b91 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @reivilibre @clokep
    reivilibre and clokep committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    93e1237 View commit details
    Browse the repository at this point in the history

  2. Antilint

    @reivilibre
    reivilibre committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    c0aaec4 View commit details
    Browse the repository at this point in the history

  3. Lock only once for batch emulated upserts

    @reivilibre
    reivilibre committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    c456958 View commit details
    Browse the repository at this point in the history

  4. No need to manually lock

    @reivilibre
    reivilibre committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    214aacf View commit details
    Browse the repository at this point in the history