Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix a spec compliance issue where requests to the /publicRooms federation API would specify limit as a string. #12364

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Fix a spec compliance issue where requests to the /publicRooms federation API would specify limit as a string. #12364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e484e5d
Fix a spec compliance issue where requests to the `/publicRooms` fede…
reivilibre Apr 4, 2022
e3caace
Newsfile
reivilibre Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/12364.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a spec compliance issue where requests to the `/publicRooms` federation API would specify `limit` as a string.
4 changes: 2 additions & 2 deletions synapse/federation/transport/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ async def get_public_rooms(
if third_party_instance_id:
data["third_party_instance_id"] = third_party_instance_id
if limit:
data["limit"] = str(limit)
data["limit"] = limit
if since_token:
data["since"] = since_token

Expand Down Expand Up @@ -509,7 +509,7 @@ async def get_public_rooms(
if third_party_instance_id:
args["third_party_instance_id"] = (third_party_instance_id,)
if limit:
args["limit"] = [str(limit)]
args["limit"] = [limit]
if since_token:
args["since"] = [since_token]

Expand Down