Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix synapse_event_persisted_position metric #12390

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Fix synapse_event_persisted_position metric #12390

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9888b8b
Fix `synapse_event_persisted_position` metric
richvdh Apr 6, 2022
2ddd15e
Merge branch 'develop' into rav/fix_event_persisted_position
richvdh Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/12390.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug introduced in Synapse 1.49.0 which caused the `synapse_event_persisted_position` metric to have invalid values.
6 changes: 3 additions & 3 deletions synapse/storage/databases/main/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,9 @@ async def _persist_events_and_state_updates(
)
persist_event_counter.inc(len(events_and_contexts))

if stream < 0:
# backfilled events have negative stream orderings, so we don't
# want to set the event_persisted_position to that.
if not use_negative_stream_ordering:
# we don't want to set the event_persisted_position to a negative
# stream_ordering.
synapse.metrics.event_persisted_position.set(
events_and_contexts[-1][0].internal_metadata.stream_ordering
)
Expand Down