-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update mypy to 0.950 and fix complaints #12650
Commits on May 5, 2022
-
David Robertson committed
May 5, 2022 Configuration menu - View commit details
-
Copy full SHA for 68788fa - Browse repository at this point
Copy the full SHA 68788faView commit details -
Ignore false positive in synapse.handler.message
Not really fair to call this a false positive since our annotation is incorrect, but screw it.
David Robertson committedMay 5, 2022 Configuration menu - View commit details
-
Copy full SHA for bfd4913 - Browse repository at this point
Copy the full SHA bfd4913View commit details -
Fix false positive in synapse.appservice.api
This function is passed an arbitrary JSON value, not a JSONDict.
David Robertson committedMay 5, 2022 Configuration menu - View commit details
-
Copy full SHA for fb11e63 - Browse repository at this point
Copy the full SHA fb11e63View commit details -
Ignore false positive in synapse.config.appservice
David Robertson committedMay 5, 2022 Configuration menu - View commit details
-
Copy full SHA for fd5b09b - Browse repository at this point
Copy the full SHA fd5b09bView commit details -
Ignore false positive in synapse.events.presence_router
David Robertson committedMay 5, 2022 Configuration menu - View commit details
-
Copy full SHA for b5228ca - Browse repository at this point
Copy the full SHA b5228caView commit details
Commits on May 6, 2022
-
Try to fix complaints about unawaited coroutines
David Robertson committedMay 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 8459efa - Browse repository at this point
Copy the full SHA 8459efaView commit details -
Fix tests.storage.test_monthly_active_users
Before the recent changes, both expressions assigned to D were coroutines. Now the second expression is a synchronous function returning a deferred. ``` tests/storage/test_monthly_active_users.py:237: error: Incompatible types in assignment (expression has type "Deferred[None]", variable has type "Coroutine[Any, Any, None]") [assignment] ```
David Robertson committedMay 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 227e4cb - Browse repository at this point
Copy the full SHA 227e4cbView commit details -
Mypy now includes python/typeshed#6653 which triggered ``` stubs/sortedcontainers/sorteddict.pyi:88: error: Signature of "update" incompatible with supertype "MutableMapping" [override] stubs/sortedcontainers/sorteddict.pyi:88: note: Superclass: stubs/sortedcontainers/sorteddict.pyi:88: note: @overload stubs/sortedcontainers/sorteddict.pyi:88: note: def update(self, SupportsKeysAndGetItem[_KT, _VT], **kwargs: _VT) -> None stubs/sortedcontainers/sorteddict.pyi:88: note: @overload stubs/sortedcontainers/sorteddict.pyi:88: note: def update(self, Iterable[Tuple[_KT, _VT]], **kwargs: _VT) -> None stubs/sortedcontainers/sorteddict.pyi:88: note: @overload stubs/sortedcontainers/sorteddict.pyi:88: note: def update(self, **kwargs: _VT) -> None stubs/sortedcontainers/sorteddict.pyi:88: note: Subclass: stubs/sortedcontainers/sorteddict.pyi:88: note: @overload stubs/sortedcontainers/sorteddict.pyi:88: note: def update(self, Mapping[_KT, _VT], **kwargs: _VT) -> None stubs/sortedcontainers/sorteddict.pyi:88: note: @overload stubs/sortedcontainers/sorteddict.pyi:88: note: def update(self, Iterable[Tuple[_KT, _VT]], **kwargs: _VT) -> None stubs/sortedcontainers/sorteddict.pyi:88: note: @overload stubs/sortedcontainers/sorteddict.pyi:88: note: def update(self, **kwargs: _VT) -> None ```
David Robertson committedMay 6, 2022 Configuration menu - View commit details
-
Copy full SHA for e1993b4 - Browse repository at this point
Copy the full SHA e1993b4View commit details -
Suppress false positive when calling run_as_background_process
David Robertson committedMay 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 7dade80 - Browse repository at this point
Copy the full SHA 7dade80View commit details -
This suppresses the complaint ``` synapse/app/_base.py:491: error: Cannot instantiate abstract class "init" with abstract attribute "__exit__" [abstract] ``` by including the change in https://github.com/getsentry/sentry-python/p I can't see anything obviously terrible in the changelogs; see https://github.com/getsentry/sentry-python/releases Additionally, we don't upper bound sentry-sdk, so fresh installations might be using this version anyway.
David Robertson committedMay 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 36d74eb - Browse repository at this point
Copy the full SHA 36d74ebView commit details -
David Robertson committed
May 6, 2022 Configuration menu - View commit details
-
Copy full SHA for b99d5ab - Browse repository at this point
Copy the full SHA b99d5abView commit details -
Use
result: object
to make ignores unnecessaryDavid Robertson committedMay 6, 2022 Configuration menu - View commit details
-
Copy full SHA for a58d973 - Browse repository at this point
Copy the full SHA a58d973View commit details -
David Robertson committed
May 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 7c4f6dc - Browse repository at this point
Copy the full SHA 7c4f6dcView commit details -
Remove comment that is confused about life
David Robertson committedMay 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 88fe871 - Browse repository at this point
Copy the full SHA 88fe871View commit details -
Workaround typeignore in synapse.handlers.message
grrr at not validating. Y'all need more static typing in your lives.
David Robertson committedMay 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 2557199 - Browse repository at this point
Copy the full SHA 2557199View commit details -
David Robertson committed
May 6, 2022 Configuration menu - View commit details
-
Copy full SHA for bf59fae - Browse repository at this point
Copy the full SHA bf59faeView commit details