Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Test cancellation at every await during request handling #12674

Merged
merged 26 commits into from
Jun 7, 2022
Merged

Test cancellation at every await during request handling #12674

merged 26 commits into from
Jun 7, 2022

Commits on May 13, 2022

  1. Add _test_cancellation_at_every_await helper method 

    Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah authored and Sean Quah committed May 13, 2022
    Configuration menu
    Copy the full SHA
    ee4b420 View commit details
    Browse the repository at this point in the history

  2. Fix mypy thinking RoomBase.servlets is a List[function] 

    Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah authored and Sean Quah committed May 13, 2022
    Configuration menu
    Copy the full SHA
    92045c8 View commit details
    Browse the repository at this point in the history

  3. Add tests for /rooms/<room_id>/members cancellation 

    Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah authored and Sean Quah committed May 13, 2022
    Configuration menu
    Copy the full SHA
    97b6b1e View commit details
    Browse the repository at this point in the history

  4. Add tests for /rooms/<room_id>/state cancellation 

    Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah authored and Sean Quah committed May 13, 2022
    Configuration menu
    Copy the full SHA
    8d7b495 View commit details
    Browse the repository at this point in the history

  5. Add dummy newsfile

    Sean Quah authored and Sean Quah committed May 13, 2022
    Configuration menu
    Copy the full SHA
    b7aa039 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Merge remote-tracking branch 'origin/develop' into squah/test_cancell… 

    …ation_at_every_await
    Sean Quah committed May 27, 2022
    Configuration menu
    Copy the full SHA
    91376e9 View commit details
    Browse the repository at this point in the history

  2. Write a proper newsfile

    Sean Quah committed May 27, 2022
    Configuration menu
    Copy the full SHA
    c980eff View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Reword failure message about await_result=False

    Sean Quah committed May 31, 2022
    Configuration menu
    Copy the full SHA
    4bf4738 View commit details
    Browse the repository at this point in the history

  2. request_number starts at 1

    Sean Quah committed May 31, 2022
    Configuration menu
    Copy the full SHA
    85a051e View commit details
    Browse the repository at this point in the history

  3. Use reactor.advance() instead of reactor.pump()

    Sean Quah committed May 31, 2022
    Configuration menu
    Copy the full SHA
    1ec2689 View commit details
    Browse the repository at this point in the history

  4. Outdent else branch

    Sean Quah committed May 31, 2022
    Configuration menu
    Copy the full SHA
    2cc45c3 View commit details
    Browse the repository at this point in the history

  5. Un-instance method a bunch of functions

    Sean Quah committed May 31, 2022
    Configuration menu
    Copy the full SHA
    9543d43 View commit details
    Browse the repository at this point in the history

  6. Return a FakeChannel from _test_cancellation_at_every_await and l… 

    …et the caller test the status code
    Sean Quah committed May 31, 2022
    Configuration menu
    Copy the full SHA
    74a6bc7 View commit details
    Browse the repository at this point in the history

  7. Turn create_deferred___next___patch and its return values into an o… 

    …bject
    Sean Quah committed May 31, 2022
    Configuration menu
    Copy the full SHA
    18dc8c0 View commit details
    Browse the repository at this point in the history

  8. Raise AssertionErrors ourselves

    Sean Quah committed May 31, 2022
    Configuration menu
    Copy the full SHA
    9955d92 View commit details
    Browse the repository at this point in the history

  9. Un-instance method _test_cancellation_at_every_await

    Sean Quah committed May 31, 2022
    Configuration menu
    Copy the full SHA
    32dc933 View commit details
    Browse the repository at this point in the history

  10. Revert "Fix mypy thinking RoomBase.servlets is a List[function]" 

    This reverts commit 92045c8.
    Sean Quah committed May 31, 2022
    Configuration menu
    Copy the full SHA
    633c48f View commit details
    Browse the repository at this point in the history

  11. Rename test_cancellation_at_every_await to `make_request_with_cance… 

    …llation_test` and have it make the request
    Sean Quah committed May 31, 2022
    Configuration menu
    Copy the full SHA
    2f4aeee View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Fix out-of-date docstring args

    Sean Quah committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    fa6245a View commit details
    Browse the repository at this point in the history

  2. Replace ThreadedMemoryReactorClock with MemoryReactorClock

    Sean Quah committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    3a73d6f View commit details
    Browse the repository at this point in the history

  3. Update docstring about Deferred.__next__'s behaviour

    Sean Quah committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    39ed2b3 View commit details
    Browse the repository at this point in the history

  4. Outdent the if blocks in the Deferred.__next__ patch

    Sean Quah committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    1ff9391 View commit details
    Browse the repository at this point in the history

  5. Use channel.await_result() instead of reactor.advance() on final … 

    …request
    Sean Quah committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9ebcf38 View commit details
    Browse the repository at this point in the history

  6. Take the status code from the Request instead of the `respond_with_… 

    …json` mock
    Sean Quah committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    2a5b800 View commit details
    Browse the repository at this point in the history

  7. Reword comments about re-starting of finished logging contexts

    Sean Quah committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    a3e9cce View commit details
    Browse the repository at this point in the history

  8. When waiting for a response after a disconnect, try unblocking awaits… 

    … that we forced to block
    Sean Quah committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    1223c2d View commit details
    Browse the repository at this point in the history