Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Capture the Deferred for request cancellation in _AsyncResource #12694

Merged
merged 4 commits into from
May 10, 2022
Merged

Capture the Deferred for request cancellation in _AsyncResource #12694

merged 4 commits into from
May 10, 2022

Commits on May 10, 2022

  1. Capture the Deferred for request cancellation in _AsyncResource 

    All async request processing goes through `_AsyncResource`, so this is
the only place where a `Deferred` needs to be captured for cancellation.

Unfortunately, the same isn't true for determining whether a request
can be cancelled. Each of `RestServlet`, `BaseFederationServlet`,
`DirectServe{Html,Json}Resource` and `ReplicationEndpoint` have
different wrappers around the method doing the request handling and they
all need to be handled separately.

Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah committed May 10, 2022
    Configuration menu
    Copy the full SHA
    39e2532 View commit details
    Browse the repository at this point in the history

  2. Add newsfile

    Sean Quah committed May 10, 2022
    Configuration menu
    Copy the full SHA
    b6c3904 View commit details
    Browse the repository at this point in the history

  3. Update comments in SynapseRequest to be more accurate

    Sean Quah committed May 10, 2022
    Configuration menu
    Copy the full SHA
    7e1cccd View commit details
    Browse the repository at this point in the history

  4. Update comments in SynapseRequest

    Sean Quah committed May 10, 2022
    Configuration menu
    Copy the full SHA
    1d9a614 View commit details
    Browse the repository at this point in the history