Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Type annotations in synapse.databases.main.devices #13025

Merged
merged 22 commits into from
Jun 15, 2022
Merged

Type annotations in synapse.databases.main.devices #13025

merged 22 commits into from
Jun 15, 2022

Commits on Jun 10, 2022

  1. Make DeviceWorkerStore inherit from EndToEndKeyWorkerStore

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    3aa4fd2 View commit details
    Browse the repository at this point in the history

  2. key_values should be a Collection, not an Iterable 

    I'm guessing one of the DB helpers iterates over it multiple times?
    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    fecad1c View commit details
    Browse the repository at this point in the history

  3. correct get_cached_device_list_changes

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    cd24240 View commit details
    Browse the repository at this point in the history

  4. Widen the type of user_ids_to_check

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    d4acc84 View commit details
    Browse the repository at this point in the history

  5. Explicit annotations mypy couldn't deduce

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    c195d07 View commit details
    Browse the repository at this point in the history

  6. Suppress a late-binding problem

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    ff49f67 View commit details
    Browse the repository at this point in the history

  7. Workaround invariance of Dict

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    ad0f4db View commit details
    Browse the repository at this point in the history

  8. Annotate a transaction's signature

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    09ad3c4 View commit details
    Browse the repository at this point in the history

  9. annotate an LRU cache

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    e458d79 View commit details
    Browse the repository at this point in the history

  10. Correct type of context

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    a86da20 View commit details
    Browse the repository at this point in the history

  11. Type-ignore the weird stuff

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    d204223 View commit details
    Browse the repository at this point in the history

  12. devices is typed

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    0c8f7ad View commit details
    Browse the repository at this point in the history

  13. Changelog

    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    62d692c View commit details
    Browse the repository at this point in the history

  14. import Literal from typing_extensions 

    added in 3.8. One day I will remember this
    David Robertson committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    a1bf0c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Batch of suggestions from Patrick 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @clokep
    David Robertson and clokep authored Jun 14, 2022
    Configuration menu
    Copy the full SHA
    81cf5d0 View commit details
    Browse the repository at this point in the history

  2. List comprehension is neater here 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @clokep
    David Robertson and clokep authored Jun 14, 2022
    Configuration menu
    Copy the full SHA
    33e6ecc View commit details
    Browse the repository at this point in the history

  3. Ugh, missed a line

    David Robertson authored Jun 14, 2022
    Configuration menu
    Copy the full SHA
    a3257bb View commit details
    Browse the repository at this point in the history

  4. Fix typo

    David Robertson committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    ac6670c View commit details
    Browse the repository at this point in the history

  5. Revert "Correct type of context" 

    This reverts commit a86da20.
    David Robertson committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    1569b14 View commit details
    Browse the repository at this point in the history

  6. Fix the context complaint differently

    David Robertson committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    134d3da View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Revert "Fix the context complaint differently" 

    This reverts commit 134d3da.
    David Robertson committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    8395995 View commit details
    Browse the repository at this point in the history

  2. Allow context=None in _add_device_outbound_poke_to_stream_txn

    David Robertson committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    60e2ce0 View commit details
    Browse the repository at this point in the history