Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Move methods to extract the access token outside of the Auth class. #13097

Closed
wants to merge 1 commit into from
Closed

Move methods to extract the access token outside of the Auth class. #13097

wants to merge 1 commit into from

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Jun 17, 2022

Part of #13019

It does not really make sense to have those methods attached to synapse.api.auth.Auth since they are static methods, so this moves them to standalone functions in synapse.http.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

Signed-off-by: Quentin Gliech <quenting@element.io>
@sandhose sandhose requested a review from a team as a code owner June 17, 2022 11:07
@sandhose
Copy link
Member Author

Nevermind, it makes mocking in tests way harder.

@sandhose sandhose closed this Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant