This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Update locked versions of mypy and mypy-zope #13521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
changed the title
squahtx
approved these changes
Aug 15, 2022
| @@ -535,8 +535,8 @@ attrs = "*" | |||
| importlib-metadata = {version = ">=1.4", markers = "python_version < \"3.8\""} | |||
|
|
|||
| [package.extras] | |||
| test = ["aiounittest", "twisted", "tox"] | |||
| dev = ["twine (==4.0.1)", "build (==0.8.0)", "isort (==5.9.3)", "flake8 (==4.0.1)", "black (==22.3.0)", "mypy (==0.910)", "aiounittest", "twisted", "tox"] | |||
| dev = ["tox", "twisted", "aiounittest", "mypy (==0.910)", "black (==22.3.0)", "flake8 (==4.0.1)", "isort (==5.9.3)", "build (==0.8.0)", "twine (==4.0.1)"] | |||
There was a problem hiding this comment.
Not specific to this PR, but what's with the version of mypy here being stuck at 0.910?
There was a problem hiding this comment.
This is a copy of the requirements declared by matrix-common. Its dev extra pins a specific version of mypy here: https://github.com/matrix-org/matrix-python-common/blob/b1801eed82b1a9c79cfbc8f85a8c79d11855f48d/setup.cfg#L32
Poetry ignores this constraint though, because Synapse depends on matrix-common, not matrix-common[dev].
|
This seemed to cause trouble on other branches(!?!). I think something has gong wrong with caching that either causes the errors to appear (as false positives) on other branches, or to not appear (false negatives) on this branch. Going to revert this and re-open the issue. |
DMRobertson
pushed a commit
that referenced
this pull request
Aug 15, 2022
DMRobertson
pushed a commit
that referenced
this pull request
Sep 28, 2022
Presumably python/typeshed#8064 makes this ok Cherry-picked from #13521
DMRobertson
pushed a commit
that referenced
this pull request
Sep 28, 2022
python/mypy#12668 Cherry-picked from #13521
DMRobertson
pushed a commit
that referenced
this pull request
Sep 30, 2022
Presumably python/typeshed#8064 makes this ok Cherry-picked from #13521
DMRobertson
pushed a commit
that referenced
this pull request
Sep 30, 2022
python/mypy#12668 Cherry-picked from #13521
DMRobertson
pushed a commit
that referenced
this pull request
Sep 30, 2022
* Update mypy and mypy-zope * Unignore assigning to LogRecord attributes Presumably python/typeshed#8064 makes this ok Cherry-picked from #13521 * Remove unused ignores due to mypy ParamSpec fixes python/mypy#12668 Cherry-picked from #13521 * Remove additional unused ignores * Fix new mypy complaints related to `assertGreater` Presumably due to python/typeshed#8077 * Changelog * Reword changelog Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13500.