Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Optimise get_rooms_for_user (drop with_stream_ordering) #13787

Merged
merged 17 commits into from
Sep 29, 2022
Merged

Optimise get_rooms_for_user (drop with_stream_ordering) #13787

merged 17 commits into from
Sep 29, 2022

Commits on Sep 13, 2022

  1. Reimplement get_rooms_for_user and get_rooms_for_users 

    This avoids the join on `events` to get stream ordering that is mostly
unused.
    @Fizzadar
    Fizzadar committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    1008106 View commit details
    Browse the repository at this point in the history

  2. Replace calls to get_rooms_for_users_with_stream_ordering 

    None of the calls to this function ever use the stream ordering component
returned, so can just use the simplified `get_rooms_for_users`.
    @Fizzadar
    Fizzadar committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    c98bbfc View commit details
    Browse the repository at this point in the history

  3. Drop unused get_rooms_for_users_with_stream_ordering method

    @Fizzadar
    Fizzadar committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    7210fa1 View commit details
    Browse the repository at this point in the history

  4. Drop simplified cache in sync tests

    @Fizzadar
    Fizzadar committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    7719d9c View commit details
    Browse the repository at this point in the history

  5. Linting fixes

    @Fizzadar
    Fizzadar committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    b745518 View commit details
    Browse the repository at this point in the history

  6. Fix call to get_immediate

    @Fizzadar
    Fizzadar committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    661e7cf View commit details
    Browse the repository at this point in the history

  7. Add placeholder changelog file

    @Fizzadar
    Fizzadar committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    3df4579 View commit details
    Browse the repository at this point in the history

  8. Fix formatting

    @Fizzadar
    Fizzadar committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    0497004 View commit details
    Browse the repository at this point in the history

  9. Don't overwrite variable

    @Fizzadar
    Fizzadar committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    7e127f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Merge branch 'develop' into optimise-get-rooms-for-user

    @Fizzadar
    Fizzadar authored Sep 22, 2022
    Configuration menu
    Copy the full SHA
    b97ae86 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Remove blank changelog line 

    Co-authored-by: Erik Johnston <erikj@jki.re>
    @Fizzadar @erikjohnston
    Fizzadar and erikjohnston authored Sep 28, 2022
    Configuration menu
    Copy the full SHA
    7512017 View commit details
    Browse the repository at this point in the history

  2. Use simple_select_many_batch in get_rooms_for_users

    @Fizzadar
    Fizzadar committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    21c8e8d View commit details
    Browse the repository at this point in the history

  3. Use simple_select_onecol in get_rooms_for_user

    @Fizzadar
    Fizzadar committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    9907aaa View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into optimise-get-rooms-for-user 

    # Conflicts:
#	synapse/storage/databases/main/events.py
#	synapse/storage/databases/main/roommember.py
    @Fizzadar
    Fizzadar committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    ff3ae7e View commit details
    Browse the repository at this point in the history

  5. Fixed merge formatting

    @Fizzadar
    Fizzadar committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    4da7073 View commit details
    Browse the repository at this point in the history

  6. Fix current_state_events column name

    @Fizzadar
    Fizzadar committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    bd70af9 View commit details
    Browse the repository at this point in the history

  7. Always ensure we return a value for every user in get_rooms_for_users 

    The cached list (sensibly) requires that every input value has a
corresponding output.
    @Fizzadar
    Fizzadar committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    7b0e311 View commit details
    Browse the repository at this point in the history