Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't log exceptions for every non-200 response #15969

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Don't log exceptions for every non-200 response #15969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dd6092
Don't log exceptions for every non-200 response
erikjohnston Jul 20, 2023
6ef455b
Newsfile
erikjohnston Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/15969.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Allow configuring the set of workers to proxy outbound federation traffic through via `outbound_federation_restricted_to`.
4 changes: 0 additions & 4 deletions synapse/http/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,10 +327,6 @@ async def _async_render_wrapper(self, request: "SynapseRequest") -> None:
# of our stack, and thus gives us a sensible stack
# trace.
f = failure.Failure()
logger.exception(
"Error handling request",
exc_info=(f.type, f.value, f.getTracebackObject()),
)
Comment on lines -330 to -333
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this, will we still have visibility of errors (e.g. 500s) in the application that need investigation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we log them elsewhere.

To be clear: This entire block was added in #15913, so we're essentially just reverting that change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was a bit of debugging I added that crept into the final PR

self._send_error_response(f, request)

async def _async_render(
Expand Down