Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove whole table locks on push rule add/delete #16051

Merged
merged 11 commits into from
Nov 13, 2023
Merged

Remove whole table locks on push rule add/delete #16051

merged 11 commits into from
Nov 13, 2023

Commits on Aug 2, 2023

  1. Remove whole table locks on push rule add/delete 

    The statements are already executed within a transaction thus a table
level lock is unnecessary.
    @Fizzadar
    Fizzadar committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    32e0bd3 View commit details
    Browse the repository at this point in the history

  2. Add changelog

    @Fizzadar
    Fizzadar committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    0938542 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Use FOR SHARE to lock selected push rule rows on relative update

    @Fizzadar
    Fizzadar committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ab88d3f View commit details
    Browse the repository at this point in the history

  2. Fix FOR SHARE handling of push rule transactions

    @Fizzadar
    Fizzadar committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d90cef1 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Use FOR UPDATE to ensure selects conflict

    @Fizzadar
    Fizzadar committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    4dbee68 View commit details
    Browse the repository at this point in the history

  2. Rewrite highest priority rule txn to use FOR UPDATE in one query

    @Fizzadar
    Fizzadar committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    2ec17da View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into remove-push-rule-table-locks

    @Fizzadar
    Fizzadar committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    3282065 View commit details
    Browse the repository at this point in the history

  4. Remove leftover quote

    @Fizzadar
    Fizzadar committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    7d10544 View commit details
    Browse the repository at this point in the history

  5. Revert "Rewrite highest priority rule txn to use FOR UPDATE in one qu… 

    …ery"

This reverts commit 2ec17da.

# Conflicts:
#	synapse/storage/databases/main/push_rule.py
    @Fizzadar
    Fizzadar committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    576605e View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Add missing txn.execute on FOR UPDATE statement

    @Fizzadar
    Fizzadar committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    376313e View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge branch 'develop' into remove-push-rule-table-locks 

    # Conflicts:
#	synapse/storage/databases/main/push_rule.py
    @Fizzadar
    Fizzadar committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    7937ac0 View commit details
    Browse the repository at this point in the history