This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Cache token introspection response from OIDC provider #16117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Shay
commented
Aug 15, 2023
|
Have requested review from @sandhose just to triple check this is the correct logic. |
|
@erikjohnston per the meeting - are you fine with me going ahead and merging this? |
|
Why? |
|
By why, I mean yes! Sorry, got distracted writing that one word response.... |
|
Merge it! |
|
Merged #16117 into develop, thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an expiring cache to the result of the
_introspect_tokenof theMSC3861DelegatedAuthclass. The cache expires after five minutes, and the token introspection response is checked for expiration both when the response is pulled from the cache and when the response is received over network (although I am not sure if the second check is necessary, would the authorizing server ever send an introspection response with an expiredexpfield?).A follow-on PR will add an endpoint for receiving revocations from the authorizing server.