This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Convert state delta processing from a dict to attrs. #16469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
approved these changes
Oct 11, 2023
DMRobertson
reviewed
Oct 11, 2023
Comment on lines
+29
to
+38
| stream_id: int | ||
| room_id: str | ||
| event_type: str | ||
| state_key: str | ||
|
|
||
| event_id: Optional[str] | ||
| """new event_id for this state key. None if the state has been deleted.""" | ||
|
|
||
| prev_event_id: Optional[str] | ||
| """previous event_id for this state key. None if it's new state.""" |
There was a problem hiding this comment.
I even double-checked that this matches the DB types :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #16431, but also just gives better type hints.