Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add new module API for adding custom fields to events unsigned section #16549

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

erikjohnston
Copy link
Member

No description provided.

@erikjohnston erikjohnston force-pushed the erikj/events_unsigned_module_api branch from 64253d2 to f607aeb Compare October 25, 2023 10:20
Comment on lines +19 to +23
```python
async def add_field_to_unsigned(
event: EventBase,
) -> JsonDict:
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts:

  • the module doesn't know who the event is destined for. Would it be useful to include a receipient mxid/device here? (I'm thinking of e.g. txn ids, which we only send down to the device that requested it). I expect the answer is "we don't need it now, but we can add it in the future if it's necessary".
  • Could the callback return different things in different invocations for the same event? If so---do we care/need to worry?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think it could be useful in the future, but it's not needed for now and I don't really want to have to do the refactoring to support it right now. As you say, its easy to add later.
  2. Yes, the callback can give different things for the same event, but that doesn't matter

Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few thoughts that it would be good to check up on before commiting, but otherwise LGMT

@erikjohnston erikjohnston enabled auto-merge (squash) October 25, 2023 15:23
@erikjohnston erikjohnston merged commit c02406a into develop Oct 27, 2023
43 checks passed
@erikjohnston erikjohnston deleted the erikj/events_unsigned_module_api branch October 27, 2023 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants