Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Avoid updating the same rows multiple times with simple_update_many_txn. #16609

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Avoid updating the same rows multiple times with simple_update_many_txn. #16609

merged 2 commits into from
Nov 7, 2023

Conversation

clokep
Copy link
Member

@clokep clokep commented Nov 7, 2023

Right now when we use simple_update_many_txn (or simple_update_many) it appends the arguments twice meaning each row is found and updated twice.

I noticed this while writing the tests in #16596.

Logic has existed since it was added in #12252.

This is used when:

  • Adding client IPs to the database.
  • Updating unread counts based on processing of receipts.
  • The set_device_id_for_pushers background update.

DMRobertson
DMRobertson approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to the universal 2x speedup. (/s)

More seriously: nice find.

@clokep clokep marked this pull request as ready for review November 7, 2023 18:39
@clokep clokep requested a review from a team as a code owner November 7, 2023 18:39
@clokep clokep removed the request for review from a team November 7, 2023 18:39
@clokep clokep merged commit 455ef04 into develop Nov 7, 2023
39 of 41 checks passed
@clokep clokep deleted the clokep/update-once branch November 7, 2023 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clokep @DMRobertson