This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Sentry Alert configuration based on production and development environment #16738
Merged
erikjohnston
merged 8 commits into
matrix-org:develop
from
zeeshanrafiqrana:zeeshan/sentry-environment
Dec 12, 2023
Merged
Sentry Alert configuration based on production and development environment #16738
erikjohnston
merged 8 commits into
matrix-org:develop
from
zeeshanrafiqrana:zeeshan/sentry-environment
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue Associated with this PR: Sentry Alert configuration based on production and development environment |
erikjohnston
reviewed
Dec 8, 2023
(Sign off has been completed out-of-band) |
erikjohnston
suggested changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry, I've missed the fact that'll you need to:
- add a changelog file (as per the contributing guide); and
- add a brief description of the new option at https://github.com/matrix-org/synapse/blob/10ada2ff6d2a08108edf5b4dbe6562cc9465523d/docs/usage/configuration/config_documentation.md#sentry
Hopefully that should only take ten minutes.
erikjohnston
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the wording a little bit to match our style, but they're only minor tweaks,
Thanks for your contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)