This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an (untested) general sketch of how to use wrapClientTLS to implement TLS over IPv6, as well as faster connections over IPv4.
Can one of the admins verify this patch? |
4 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
glyph
added a commit
to glyph/synapse
that referenced
this pull request
Dec 11, 2016
Similar to matrix-org#1689, but for endpoint.py
kyrias
suggested changes
Dec 11, 2016
) | ||
tlsCreator = self.policyForHTTPS.creatorForNetloc(uri.host, uri.port) | ||
def endpoint_factory(reactor, host, port, **kw): | ||
return wrapClientTLS(tlsCreator, HostnameEndpoint(reactor, host, port, **kw) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing closing paren
kyrias
pushed a commit
to kyrias/synapse
that referenced
this pull request
Dec 12, 2016
Similar to matrix-org#1689, but for endpoint.py
Merged
kyrias
added a commit
to kyrias/synapse
that referenced
this pull request
Dec 12, 2016
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an (untested) general sketch of how to use wrapClientTLS to implement TLS over IPv6, as well as faster connections over IPv4.