This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix bug where current_state_events renamed to current_state_ids #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #1785 |
|
This looks like it probably fixes the ISE in #1785. I would appreciate if we had a slightly better idea of what the code is doing here since I think it should only be reached via https://github.com/matrix-org/synapse/blob/v0.18.7-rc2/synapse/federation/federation_server.py#L559 |
|
It seems a bit weird to attempt to store an outlier with state since I thought the whole point of an outlier was that it was an event without state. Would it make more sense to treat the event as some weird form of backfill in this case? |
|
We probably don't persist it, but use it to do some auth on the event. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.