This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Phone number registration / login support v2 #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes from #1971
Only offer msisdn flows if the x_show_msisdn option is given.
| # Android <=0.6.9 have fallen below an acceptable threshold, this | ||
| # parameter should go away and we should always advertise msisdn flows. | ||
| show_msisdn = False | ||
| print body |
| flows += [ | ||
| [LoginType.MSISDN, LoginType.RECAPTCHA], | ||
| [LoginType.MSISDN, LoginType.EMAIL_IDENTITY, LoginType.RECAPTCHA], | ||
| ] |
There was a problem hiding this comment.
Generally we prefer flows.extend([..]) rather than concatenating two lists, but meh
There was a problem hiding this comment.
Ah interesting, I wrote that first but then sort of concluded the opposite.
|
lgtm |
anoadragon453
added a commit
that referenced
this pull request
Jun 12, 2020
Fixes bug introduced in #1994
anoadragon453
added a commit
that referenced
this pull request
Jun 15, 2020
The spec [states](https://matrix.org/docs/spec/client_server/r0.6.1#phone-number) that `m.id.phone` requires the field `country` and `phone`. In Synapse, we've been enforcing `country` and `number`. I am not currently sure whether this affects any client implementations. This issue was introduced in #1994.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1971 with fix for old clients
Presented in two parts (commits)