Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Optimise LoggingContext creation and copying #2792

Merged
merged 2 commits into from
Jan 17, 2018

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 16, 2018

It turns out that the only thing we use the dict of LoggingContext for is
request, and given we create lots of LoggingContexts and then copy them every
time we do a db transaction or log line, using the dict seems a bit
redundant. Let's try to optimise things by making the request attribute
explicit.

(factored out from #2775)

It turns out that the only thing we use the __dict__ of LoggingContext for is
`request`, and given we create lots of LoggingContexts and then copy them every
time we do a db transaction or log line, using the __dict__ seems a bit
redundant. Let's try to optimise things by making the request attribute
explicit.
@richvdh
Copy link
Member Author

richvdh commented Jan 16, 2018

(this appears to be failing because it is waiting for #2789 to land)

@richvdh richvdh merged commit 1067b96 into develop Jan 17, 2018
@richvdh richvdh deleted the rav/optimise_logging_context branch January 17, 2018 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants