This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use stream cache in get_linearized_receipts_for_room #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids us from uncessarily hitting the database when there has been no change for the room
richvdh
suggested changes
Jul 10, 2018
synapse/storage/receipts.py
Outdated
| @@ -164,6 +163,16 @@ def get_linearized_receipts_for_room(self, room_id, to_key, from_key=None): | |||
| Returns: | |||
| list: A list of receipts. | |||
| """ | |||
| if from_key: | |||
There was a problem hiding this comment.
shouldn't this be if from_key is not None?
synapse/storage/receipts.py
Outdated
| @@ -164,6 +163,16 @@ def get_linearized_receipts_for_room(self, room_id, to_key, from_key=None): | |||
| Returns: | |||
| list: A list of receipts. | |||
| """ | |||
| if from_key: | |||
| if not self._receipts_stream_cache.has_entity_changed(room_id, from_key): | |||
There was a problem hiding this comment.
can we have a comment here please? why is this a sensible thing to do?
richvdh
approved these changes
Jul 12, 2018
synapse/storage/receipts.py
Outdated
| @@ -164,6 +165,18 @@ def get_linearized_receipts_for_room(self, room_id, to_key, from_key=None): | |||
| Returns: | |||
| list: A list of receipts. | |||
There was a problem hiding this comment.
could you clarify that this is a Deferred[list] ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids us from uncessarily hitting the database when there has been
no change for the room