Add systemd-python to optional dependencies #4339
Conversation
silkeh
force-pushed
the
add-systemd-python
branch
from
d5cdf46
to
0659104
Compare
Using systemd-python allows for logging to the systemd journal, as is documented in: `synapse/contrib/systemd/log_config.yaml`. Signed-off-by: Silke Hofstra <silke@slxh.eu>
silkeh
force-pushed
the
add-systemd-python
branch
from
0659104
to
5c297d5
Compare
|
This seems reasonable, but the CI is failing with a failure to install It's not needed to run the unit tests, so I'm wondering if we should change the |
|
@richvdh I think excluding systemd-python from |
Which I think means that you think this PR is incorrect? |
Codecov Report
@@ Coverage Diff @@
## develop #4339 +/- ##
===========================================
+ Coverage 61.56% 61.57% +0.01%
===========================================
Files 332 332
Lines 34270 34271 +1
Branches 5650 5651 +1
===========================================
+ Hits 21097 21103 +6
+ Misses 11656 11653 -3
+ Partials 1517 1515 -2 |
|
That change there should do -- the branch just needs merging forward. |
synapse/python_dependencies.py
Outdated
| for opt in CONDITIONAL_REQUIREMENTS.values(): | ||
| deps = set(opt) | deps | ||
| for name, opts in CONDITIONAL_REQUIREMENTS.items(): | ||
| if name not in ["systemd"]: |
There was a problem hiding this comment.
I'm not sure what the point of including systemd in CONDITIONAL_REQUIREMENTS in the first place is?
There was a problem hiding this comment.
oh wait, now I do. But I don't think changing this will change the behaviour for [all], which seems to be done in setup.py.
There was a problem hiding this comment.
adfghdfh yes of course it won't :/
…into add-systemd-python
|
@hawkowl: thanks for picking this up! |
Using
systemd-pythonallows for logging to the systemd journal, as is documented in:synapse/contrib/systemd/log_config.yaml.This PR is based on #4325 (will rebase once merged), and adds the package under
systemd.Pull Request Checklist