This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Give the IS a bunch more 3pid invite context #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| room_name, | ||
| user.to_string(), | ||
| inviter_display_name, | ||
| inviter_avatar_url |
There was a problem hiding this comment.
Please can we kwarg this, this looks horribly error-prone.
|
LGTM |
This allows it to form richer emails
illicitonion
force-pushed
the
daniel/invitemetadata
branch
from
777bd04
to
0311612
Compare
illicitonion
added a commit
that referenced
this pull request
Dec 16, 2015
Give the IS a bunch more 3pid invite context This allows it to form richer emails
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows it to form richer emails