This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Matthew/no identicons #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s vector-web/vector-im#346
|
This will fix element-hq/element-web#346 |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop synapse generating implicit identicons by default. We should generate them clientside with the appropriate branding for a given client if we want them.
The alternative to this would be to change vector to ignore any identicons which have an #auto URL suffix, but this seems like a cleaner solution (albeit one that will break identicon generation on the Matrix Console apps until we fix them to render their own ones).