This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Support inviting 3pids in /createRoom #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| address, | ||
| id_server, | ||
| None, | ||
| None, |
There was a problem hiding this comment.
Can we use named args here? So that I know what's being set to None
There was a problem hiding this comment.
Will the do_3pid_invite be ratelimited?
There was a problem hiding this comment.
Can we use named args here? So that I know what's being set to
None
Done.
Will the do_3pid_invite be ratelimited?
It just ends up calling create_and_send_event I think, so its probably fiiiiiiiiiine
|
Other than the potential for rate-limiting problems LGTM |
erikjohnston
added a commit
that referenced
this pull request
Jan 5, 2016
Support inviting 3pids in /createRoom
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix-org/matrix-spec-proposals#247
matrix-org/sytest#128