This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add time-based account expiration #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babolivier
force-pushed
the
babolivier/account_expiration
branch
2 times, most recently
from
a76118b
to
65322bc
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5027 +/- ##
===========================================
- Coverage 61.59% 59.77% -1.82%
===========================================
Files 332 328 -4
Lines 34227 34114 -113
Branches 5643 5631 -12
===========================================
- Hits 21082 20393 -689
- Misses 11631 12218 +587
+ Partials 1514 1503 -11 |
|
One thing I'm still not sure about wrt this PR is the unit of time for the validity period. I chose weeks, but it might make as much sense (or even more) to change that to days? |
erikjohnston
previously requested changes
Apr 9, 2019
erikjohnston
approved these changes
Apr 9, 2019
babolivier
force-pushed
the
babolivier/account_expiration
branch
from
f0fc335
to
747aa9f
Compare
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.