This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Change the way we do public room list fetching #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matrixbot: test this please. |
|
|
||
| # FIXME (erikj): START is no longer a valid value | ||
| defer.returnValue({"start": "START", "end": "END", "chunk": chunk}) | ||
| defer.returnValue({"start": "START", "end": "END", "chunk": result}) | ||
|
|
||
| @defer.inlineCallbacks | ||
| def get_room_avatar_url(self, room_id): |
There was a problem hiding this comment.
it looks like get_room_avatar isn't called anywhere now.
| @@ -876,39 +876,71 @@ class RoomListHandler(BaseHandler): | |||
|
|
|||
| @defer.inlineCallbacks | |||
| def get_public_room_list(self): | |||
| chunk = yield self.store.get_rooms(is_public=True) | |||
There was a problem hiding this comment.
get_rooms is only called in one place now, and that is to get the number of rooms in synapse.app.homeserver:phone_stats_home. It might be nice to kill it for good.
|
The changes themselves LGTM. It would be great to finish the cleanup and remove the mostly unused |
|
matrixbot: test this please |
erikjohnston
force-pushed
the
erikj/public_room_fix
branch
from
959233f
to
f8aae79
Compare
|
LGTM |
erikjohnston
added a commit
that referenced
this pull request
Feb 3, 2016
Change the way we do public room list fetching
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.