This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make adding push rules idempotent #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| conditions_json, actions_json, | ||
| ) | ||
|
|
||
| def _upsert_push_rule_txn( |
There was a problem hiding this comment.
Note that this can only be called if txn is locking the table
|
LGTM with one comment |
Also remove the **kwargs from the add_push_rule method. Fixes https://matrix.org/jira/browse/SYN-391
NegativeMjark
force-pushed
the
markjh/idempotent_rules
branch
from
120cee0
to
a9c9868
Compare
NegativeMjark
added a commit
that referenced
this pull request
Feb 16, 2016
Make adding push rules idempotent Also remove the **kwargs from the add_push_rule method. Fixes https://matrix.org/jira/browse/SYN-391
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the **kwargs from the add_push_rule method.
Fixes https://matrix.org/jira/browse/SYN-391