This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
handlers/_base: allow peeking users to see events in rooms they are members of #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
…embers of According to spec guests should be able to use the normal /sync API to participate in rooms that they have joined. Signed-off-by: Patrik Oldsberg <patrik.oldsberg@ericsson.com>
|
@matrixbot ok to test |
|
Ok, np |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to spec guests should be able to use the normal /sync API to participate in rooms that they have joined. (Last sentence of 11.13.2.1 GET /_matrix/client/r0/events)
I'm not sure about the logic here though, so gonna need some review. I'm a bit confused about filtering out the room history visibility event for peeking users, and also defaulting to
return Trueif the room visibility is set to an invalid value.