This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
handlers/_base: don't allow room create event to be changed #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Signed-off-by: Patrik Oldsberg <patrik.oldsberg@ericsson.com>
|
@matrixbot ok to test |
erikjohnston
added a commit
that referenced
this pull request
Mar 4, 2016
handlers/_base: don't allow room create event to be changed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning of the m.room.create spec says
This could arguably be interpreted as that specific event not being changed, or the m.room.create state as a whole. I chose to interpret it as the latter, which I also think makes sense, as it is currently possible to e.g. change the creator key of the create state.
In either case this is a spec bug as well.