This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix inserting bytes as text in censor_redactions
#6185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/fix_censored_evnets
branch
from
October 8, 2019 15:18
feec380
to
e7631d8
Compare
Test failures are due to develop not being merged in. |
richvdh
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than incomprehensible changelog
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
richvdh
pushed a commit
that referenced
this pull request
Oct 17, 2019
Fix inserting bytes as text in `censor_redactions`
richvdh
added a commit
that referenced
this pull request
Oct 17, 2019
babolivier
added a commit
that referenced
this pull request
Oct 18, 2019
Synapse 1.4.1 (2019-10-18) ========================== No changes since 1.4.1rc1. Synapse 1.4.1rc1 (2019-10-17) ============================= Bugfixes -------- - Fix bug where redacted events were sometimes incorrectly censored in the database, breaking APIs that attempted to fetch such events. ([\#6185](#6185), [5b0e994](5b0e994))
This was referenced Jan 24, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FTR this is based off of master in case we want to ship a hot fix.